Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6495)

Unified Diff: chrome/renderer/resources/extensions/extension_options_events.js

Issue 431503002: Implement autosizing for <extensionoptions> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/extension_options_events.js
diff --git a/chrome/renderer/resources/extensions/extension_options_events.js b/chrome/renderer/resources/extensions/extension_options_events.js
index a93f05ca5edf12d76cf5a9dbe9c0c59c40de46b5..f87b1572b2061008bba3af8afb9f8f13fcb68e56 100644
--- a/chrome/renderer/resources/extensions/extension_options_events.js
+++ b/chrome/renderer/resources/extensions/extension_options_events.js
@@ -9,11 +9,13 @@ var CreateEvent = function(name) {
return new EventBindings.Event(name, undefined, eventOpts);
};
+var SizeChangedEvent = CreateEvent('extensionOptionsInternal.onSizeChanged');
not at google - send to devlin 2014/07/30 17:44:57 why can't this be in the EXTENSION_OPTIONS_EVENTS
ericzeng 2014/07/30 23:29:26 EXTENSION_OPTIONS_EVENTS is propagated up to the D
+
var EXTENSION_OPTIONS_EVENTS = {
'load': {
evt: CreateEvent('extensionOptionsInternal.onLoad'),
fields: []
- },
+ }
}
/**
@@ -27,6 +29,7 @@ function ExtensionOptionsEvents(extensionOptionsInternal, viewInstanceId) {
// Sets up events.
ExtensionOptionsEvents.prototype.setup = function() {
+ this.setupSizeChangedEvent();
for (var eventName in EXTENSION_OPTIONS_EVENTS) {
this.setupEvent(eventName, EXTENSION_OPTIONS_EVENTS[eventName]);
}
@@ -54,5 +57,11 @@ ExtensionOptionsEvents.prototype.setupEvent = function(name, info) {
this.extensionOptionsInternal.setupEventProperty(name);
};
+ExtensionOptionsEvents.prototype.setupSizeChangedEvent = function() {
+ SizeChangedEvent.addListener(function(e) {
+ this.extensionOptionsInternal.onSizeChanged(e.width, e.height);
+ }.bind(this), {instanceId: this.viewInstanceId});
+}
+
exports.ExtensionOptionsEvents = ExtensionOptionsEvents;
exports.CreateEvent = CreateEvent;

Powered by Google App Engine
This is Rietveld 408576698