QUIC - Added separate error condition for invalid expiry seconds and

QUIC - Added separate error condition for invalid expiry seconds and
updated the UMA histograms.

Fixed wtc's comments in https://codereview.chromium.org/416983005/diff/20001/net/quic/crypto/quic_crypto_client_config.cc

R=asvitkine@chromium.org, wtc@chromium.org, jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287251

[Alexei Svitkine (slow), 2014-07-30 15:09:27]

lgtm

[ramant (doing other things), 2014-07-31 14:52:58]

Hi Wan-Teh,
  Would appreciate if you could take a look when you have few minutes.

thanks much
raman

[jar (doing other things), 2014-07-31 23:23:10]

https://codereview.chromium.org/431483002/diff/1/net/quic/crypto/quic_crypto_...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/431483002/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_client_config.cc:93: return false;
Q: Do we also have  histogram showing "how expired" (in minutes?? or hours?) the
configuration was?  That would be very helpful in discussion about how long our
config *should* be (if we want to raise the usability rate of config).

WDYT?

[ramant (doing other things), 2014-08-02 00:01:33]

https://codereview.chromium.org/431483002/diff/1/net/quic/crypto/quic_crypto_...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/431483002/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_client_config.cc:93: return false;
On 2014/07/31 23:23:10, jar wrote:
> Q: Do we also have  histogram showing "how expired" (in minutes?? or hours?)
the
> configuration was?  That would be very helpful in discussion about how long
our
> config *should* be (if we want to raise the usability rate of config).
> 
> WDYT?

Done.

[jar (doing other things), 2014-08-03 01:22:29]

Thanks for adding the expiry time histogram!

LGTM

[ramant (doing other things), 2014-08-03 04:33:04]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-03 04:34:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/431483002/20001

[commit-bot: I haz the power, 2014-08-03 05:56:21]

Change committed as 287251

[wtc, 2014-08-04 23:36:30]

Patch set 2 LGTM.

https://codereview.chromium.org/431483002/diff/20001/net/quic/crypto/quic_cry...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/431483002/diff/20001/net/quic/crypto/quic_cry...
net/quic/crypto/quic_crypto_client_config.cc:43:
SERVER_CONFIG_INVALID_EXPIRY_SECONDS = 4,

Nit: this can be shortened to "SERVER_CONFIG_INVALID_EXPIRY".

If you make this change, please update histograms.xml as well.

https://codereview.chromium.org/431483002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/431483002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:15119: +    How expired server config is
for sending InchoateClientHello to the server.

Nit: InchoateClientHello => inchoate ClientHello

[ramant (doing other things), 2014-08-05 22:07:25]

Made the changes in CL:
  https://codereview.chromium.org/443763002/

https://codereview.chromium.org/431483002/diff/20001/net/quic/crypto/quic_cry...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/431483002/diff/20001/net/quic/crypto/quic_cry...
net/quic/crypto/quic_crypto_client_config.cc:43:
SERVER_CONFIG_INVALID_EXPIRY_SECONDS = 4,
On 2014/08/04 23:36:30, wtc wrote:
> 
> Nit: this can be shortened to "SERVER_CONFIG_INVALID_EXPIRY".
> 
> If you make this change, please update histograms.xml as well.

Done.

https://codereview.chromium.org/431483002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/431483002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:15119: +    How expired server config is
for sending InchoateClientHello to the server.
On 2014/08/04 23:36:30, wtc wrote:
> 
> Nit: InchoateClientHello => inchoate ClientHello

Done.