Issue 43147: Merge 11279 - Added a PasswordManagerTableModelObserver to listen for row cou...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43147: Merge 11279 - Added a PasswordManagerTableModelObserver to listen for row cou... (Closed)

Created:
11 years, 9 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/169/src/

Visibility:
Public.

Merge 11279 - Added a PasswordManagerTableModelObserver to listen for row count change events. PasswordManagerView and PasswordManagerExceptionsView are listening to the event. Move the |instance_| variable from static global to the respective class to avoid future misuse of the variable. Review URL: http://codereview.chromium.org/39313 BUG=8345 TBR=hclam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11553

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -14 lines)			Patch
M	chrome/browser/views/password_manager_exceptions_view.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/views/password_manager_exceptions_view.cc	View	4 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/views/password_manager_view.h	View	7 chunks	+31 lines, -3 lines	0 comments	Download
M	chrome/browser/views/password_manager_view.cc	View	8 chunks	+15 lines, -9 lines	0 comments	Download

Total messages: 1 (0 generated)