Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 43146: Review request: fix issue 8684 -- RTL Regression: Text should be right aligned for RTL languages on (Closed)

Created:
9 years, 5 months ago by xji
Modified:
7 years, 1 month ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL fixes issue 8684 -- RTL Regression: Text should be right aligned for RTL languages on "Bookmark Manager" (http://crbug.com/8684) The problem is canvas.DrawStringWithHalo() within BookmarkTableView::PaintAltText() always use left alignment. The fix is to pass the correct canvas text alignment when DrawStringWithHalo(). Test: 1. Run Hebrew Chrome 2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog 3. Select "Search" 4. Observe Without the fix: Text "Enter a query in the text field above to search your bookmarks" is left aligned With the fix: The above text is right aligned Hebrew Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/views/bookmark_table_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
xji
9 years, 5 months ago (2009-03-12 18:13:43 UTC) #1
sky
LGTM
9 years, 5 months ago (2009-03-12 18:21:22 UTC) #2
idana
LGTM
9 years, 5 months ago (2009-03-12 19:23:49 UTC) #3
jungshik at Google
lgtm
9 years, 5 months ago (2009-03-12 22:08:46 UTC) #4
jeremy
9 years, 5 months ago (2009-03-15 07:12:25 UTC) #5
lgtm!

Powered by Google App Engine
This is Rietveld 408576698