Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 431433006: Merge 285317 "Merge 285314 "Turn webspeech on/off when tab goes ..." (Closed)

Created:
6 years, 4 months ago by kerz_chromium
Modified:
6 years, 4 months ago
Reviewers:
qinmin
CC:
chromium-reviews, creis+watch_chromium.org, fischman+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Merge 285317 "Merge 285314 "Turn webspeech on/off when tab goes ..." > Merge 285314 "Turn webspeech on/off when tab goes fore/background" > > > Turn webspeech on/off when tab goes fore/background > > > > This change adds a toggle to turn webspeech off when tab goes background. > > And further request to turn media capture devices on will be denied. > > So Both WebRTC and webSpeech won't be able to initiate new requests when tab is in background. > > > > This CL also fixed a bug in the original CL that was reverted: some times recognition will not be aborted immediately after screen lock. > > The issue is caused by that calling abort() will not delete the session in SpeechRecognitionManagerImpl. > > So if a SpeechRecognition objects calls multiple start(), several sessions with the same request_id will be created. > > And when passing the request_id to abort the sessions, only 1 session will be aborted > > This change requests the all sessions in the same render view to be aborted. > > Thus solving the above issue. > > > > BUG=396054 > > R=jochen@chromium.org, tsepez@chromium.org, xians@chromium.org > > > > Review URL: https://codereview.chromium.org/415933002 > > TBR=qinmin@chromium.org > > Review URL: https://codereview.chromium.org/419503005 TBR=qinmin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M chrome/browser/media/media_stream_devices_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/speech_recognition_messages.h View 1 chunk +9 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/speech_recognition_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/speech_recognition_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kerz_chromium
6 years, 4 months ago (2014-07-30 02:25:00 UTC) #1
kerz_chromium
6 years, 4 months ago (2014-07-30 02:25:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r286376 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698