Make SafeBrowsingResourceThrottleFactory::RegisterFactory() not optional.

Make SafeBrowsingResourceThrottleFactory::RegisterFactory() not optional.

Both MOBILE_SAFE_BROWSING and FULL_SAFE_BROWSING need the factory now, which
covers everyone who uses these files.  Remove the conditional code from the
header and pull shared implementation code out of the conditional sections.

BUG=none
R=sgurun@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286590

[Scott Hess - ex-Googler, 2014-07-29 22:51:15]

I don't actually see anyone using RegisterFactory(), so I'm not entirely certain
it's still relevant.  If I can remove the factory entirely, that would also be
acceptable.

This CL is stemming from a suggestion on
https://codereview.chromium.org/397853002/ about moving compile-time-config
behavior from the header to the implementation (see comment #10).

[sgurun-gerrit only, 2014-07-29 23:25:03]

On 2014/07/29 22:51:15, Scott Hess wrote:
> I don't actually see anyone using RegisterFactory(), so I'm not entirely
certain
> it's still relevant.  If I can remove the factory entirely, that would also be
> acceptable.
> 
> This CL is stemming from a suggestion on
> https://codereview.chromium.org/397853002/ about moving compile-time-config
> behavior from the header to the implementation (see comment #10).

lgtm

[Scott Hess - ex-Googler, 2014-07-30 14:54:44]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2014-07-30 14:55:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shess@chromium.org/431433002/1

[commit-bot: I haz the power, 2014-07-30 17:40:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-30 17:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 17:45:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Scott Hess - ex-Googler, 2014-07-30 18:09:11]

Oops, yes, need OWNERS for chrome/browser/renderer_host/

[Lei Zhang, 2014-07-30 18:34:38]

What about iOS? It doesn't have safe browsing at all.

[Scott Hess - ex-Googler, 2014-07-30 18:41:13]

On 2014/07/30 18:34:38, Lei Zhang wrote:
> What about iOS? It doesn't have safe browsing at all.

Per the implementation side, this class will cause a compile error if you don't
set one of those two defines.  chrome_browser.gypi only includes these files if
safe_browsing!=0 (gyp variable), iOS sets safe_browsing=0 .

[Lei Zhang, 2014-07-30 18:43:57]

On 2014/07/30 18:41:13, Scott Hess wrote:
> On 2014/07/30 18:34:38, Lei Zhang wrote:
> > What about iOS? It doesn't have safe browsing at all.
> 
> Per the implementation side, this class will cause a compile error if you
don't
> set one of those two defines.  chrome_browser.gypi only includes these files
if
> safe_browsing!=0 (gyp variable), iOS sets safe_browsing=0 .

lgtm

I've been putting guards like that at the top of the file. Didn't see it at the
bottom.

[Scott Hess - ex-Googler, 2014-07-30 18:46:05]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2014-07-30 18:47:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shess@chromium.org/431433002/1

[commit-bot: I haz the power, 2014-07-30 20:26:34]

Change committed as 286590