Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 431423002: GN support for //jingle directory (Closed)

Created:
6 years, 4 months ago by rlarocque
Modified:
6 years, 4 months ago
Reviewers:
brettw, awong
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

GN support for //jingle directory Supports GN build of //jingle, though its targets won't be linkable until its dependency //third_party/libjingle is properly supported. TBR=ajwong BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287425

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove redundant configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -5 lines) Patch
M chrome/service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A jingle/BUILD.gn View 1 1 chunk +201 lines, -0 lines 0 comments Download
M jingle/jingle.gyp View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rlarocque
Here's the conversion of the jingle/ directory, using the stubs you mentioned over e-mail. It's ...
6 years, 4 months ago (2014-08-01 22:43:57 UTC) #1
brettw
lgtm https://codereview.chromium.org/431423002/diff/1/jingle/BUILD.gn File jingle/BUILD.gn (right): https://codereview.chromium.org/431423002/diff/1/jingle/BUILD.gn#newcode27 jingle/BUILD.gn:27: configs += [ "//content:libjingle_stub_config" ] You can delete ...
6 years, 4 months ago (2014-08-03 04:22:54 UTC) #2
rlarocque
Uploaded new patch. 'git cl upload' tells me I need a reviewer for jingle/jingle.gyp. Adding ...
6 years, 4 months ago (2014-08-04 17:33:42 UTC) #3
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 4 months ago (2014-08-04 17:34:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/431423002/20001
6 years, 4 months ago (2014-08-04 17:35:46 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:59:27 UTC) #6
Message was sent while issue was closed.
Change committed as 287425

Powered by Google App Engine
This is Rietveld 408576698