Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 431393002: Revert of Stop using -Wno-sentinel with clang. (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Stop using -Wno-sentinel with clang. (https://codereview.chromium.org/427723005/) Reason for revert: breaks Google Chrome Linux http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/36758/steps/compile/logs/stdio Original issue's description: > Stop using -Wno-sentinel with clang. > > Clang works fine with -Wsentinel on 32bit linux these days. > > BUG=162818 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287061 TBR=dmikurube@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=162818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of Stop using -Wno-sentinel with clang.
6 years, 4 months ago (2014-08-01 20:11:39 UTC) #1
Nico
lgtm
6 years, 4 months ago (2014-08-01 20:12:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/431393002/1
6 years, 4 months ago (2014-08-01 20:13:32 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 20:16:15 UTC) #4
Message was sent while issue was closed. 
Change committed as 287078

Powered by Google App Engine
This is Rietveld 408576698