PDF: Handle the space bar key like page down.

PDF: Handle the space bar key like page down.

BUG=397624
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287520

[Peter Kasting, 2014-08-01 07:23:08]

https://codereview.chromium.org/431303002/diff/1/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/431303002/diff/1/pdf/instance.cc#newcode512
pdf/instance.cc:512: (is_fit_to_page && key_code == ui::VKEY_PRIOR);
You also need to treat shift-space as page up.  (Try it in normal web content.)

[Lei Zhang, 2014-08-01 19:41:22]

https://codereview.chromium.org/431303002/diff/1/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/431303002/diff/1/pdf/instance.cc#newcode512
pdf/instance.cc:512: (is_fit_to_page && key_code == ui::VKEY_PRIOR);
On 2014/08/01 07:23:08, Peter Kasting wrote:
> You also need to treat shift-space as page up.  (Try it in normal web
content.)

Neat. Never knew you can do that. Onwards to patch set 2.

[raymes, 2014-08-05 06:40:40]

Sorry was OOO for a couple of days. lgtm :)

[Lei Zhang, 2014-08-05 06:59:44]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-05 07:00:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/431303002/20001

[commit-bot: I haz the power, 2014-08-05 11:27:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-05 12:20:08]

Change committed as 287520