Source/core/html/HTMLFormElement.cpp - Issue 431273006: Fixing the case where mixed content checking for insecure form submission in secure origins is brea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 431273006: Fixing the case where mixed content checking for insecure form submission in secure origins is brea… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing adamk comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/mixedContent/resources/frame-with-invisible-DOM-with-insecure-form.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormElement.cpp

diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp

index 985b37cff00ef4c8949a3ade7c54d9a1fecdeca4..aa7a35ffc8f39460cdd05a71e8259180b2c0795d 100644

--- a/Source/core/html/HTMLFormElement.cpp

+++ b/Source/core/html/HTMLFormElement.cpp

@@ -502,7 +502,7 @@ void HTMLFormElement::parseAttribute(const QualifiedName& name, const AtomicStri

// If the new action attribute is pointing to insecure "action" location from a secure page

// it is marked as "passive" mixed content.

KURL actionURL = document().completeURL(m_attributes.action().isEmpty() ? document().url().string() : m_attributes.action());

- if (MixedContentChecker::isMixedContent(document().securityOrigin(), actionURL))

+ if (document().frame() && MixedContentChecker::isMixedContent(document().securityOrigin(), actionURL))

document().frame()->loader().mixedContentChecker()->canSubmitToInsecureForm(document().securityOrigin(), actionURL);

} else if (name == targetAttr)

m_attributes.setTarget(value);

« no previous file with comments | « LayoutTests/http/tests/security/mixedContent/resources/frame-with-invisible-DOM-with-insecure-form.html ('k') | no next file » | no next file with comments »