Fixing the case where mixed content checking for insecure form submission in secure origins is brea…

Source/core/html/HTMLFormElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 485 matching lines @@
     m_pendingAutocompleteEventsQueue->enqueueEvent(event.release());
 }
 
 void HTMLFormElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (name == actionAttr) {
         m_attributes.parseAction(value);
         // If the new action attribute is pointing to insecure "action" location from a secure page
         // it is marked as "passive" mixed content.
         KURL actionURL = document().completeURL(m_attributes.action().isEmpty() ? document().url().string() : m_attributes.action());
-        if (MixedContentChecker::isMixedContent(document().securityOrigin(), actionURL))
-            document().frame()->loader().mixedContentChecker()->canSubmitToInsecureForm(document().securityOrigin(), actionURL);
+        // Blink needs to check if the form is associted with a frame because mixed content checker

[jww, 2014/08/01 23:35:42]

Can you please wrap this comment to 80 characters? Also, should be "...because
the mixed content checker..."

[adamk, 2014/08/01 23:43:29]

I don't think this comment is useful, the very next line accesses
document().frame(), so checking that it's non-null is a clear prerequisite for
that. The bug information will remain in the history through the BUG= line in
your commit message.

[mhm, 2014/08/02 00:08:52]

Done.

[mhm, 2014/08/04 15:15:44]

Done.

+        // assumes it has a fram. See bug 398066.

[jww, 2014/08/01 23:35:42]

fram -> frame

[mhm, 2014/08/02 00:08:52]

Done.

+        if (document().frame()) {

[adamk, 2014/08/01 23:43:28]

Nit: if { if looks funny to me, please make this:

if (document().frame() && ...)

[mhm, 2014/08/04 15:15:44]

Done.

+            if (MixedContentChecker::isMixedContent(document().securityOrigin(), actionURL))
+                document().frame()->loader().mixedContentChecker()->canSubmitToInsecureForm(document().securityOrigin(), actionURL);
+        }
     } else if (name == targetAttr)
         m_attributes.setTarget(value);
     else if (name == methodAttr)
         m_attributes.updateMethodType(value);
     else if (name == enctypeAttr)
         m_attributes.updateEncodingType(value);
     else if (name == accept_charsetAttr)
         m_attributes.setAcceptCharset(value);
     else if (name == onautocompleteAttr)
         setAttributeEventListener(EventTypeNames::autocomplete, createAttributeEventListener(this, name, value, eventParameterName()));
@@ skipping 309 matching lines @@
 }
 
 void HTMLFormElement::setDemoted(bool demoted)
 {
     if (demoted)
         UseCounter::count(document(), UseCounter::DemotedFormElement);
     m_wasDemoted = demoted;
 }
 
 } // namespace