Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 431273005: DevTools: Collect JS samples when recording timeline (Closed)

Created:
6 years, 4 months ago by alph
Modified:
6 years, 4 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Collect JS samples when recording timeline BUG=363976 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179956

Patch Set 1 #

Total comments: 2

Patch Set 2 : Introduce a JSSample event instead of taking over CallStack event. #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -2 lines) Patch
M Source/devtools/front_end/sdk/CPUProfileDataModel.js View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +19 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineJSProfile.js View 1 1 chunk +42 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 7 chunks +61 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
alph
6 years, 4 months ago (2014-08-01 13:57:48 UTC) #1
yurys
lgtm https://codereview.chromium.org/431273005/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/431273005/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode260 Source/devtools/front_end/timeline/TimelineFlameChart.js:260: currentJSInvocationEndTime = e.endTime; This doesn't seem to work ...
6 years, 4 months ago (2014-08-01 15:29:18 UTC) #2
alph
https://codereview.chromium.org/431273005/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/431273005/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode260 Source/devtools/front_end/timeline/TimelineFlameChart.js:260: currentJSInvocationEndTime = e.endTime; On 2014/08/01 15:29:17, yurys wrote: > ...
6 years, 4 months ago (2014-08-01 15:44:45 UTC) #3
alph
The CQ bit was checked by alph@chromium.org
6 years, 4 months ago (2014-08-05 08:17:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/431273005/40001
6 years, 4 months ago (2014-08-05 08:18:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-05 12:07:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 13:18:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20903)
6 years, 4 months ago (2014-08-05 13:18:31 UTC) #8
alph
The CQ bit was checked by alph@chromium.org
6 years, 4 months ago (2014-08-11 14:06:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/431273005/40001
6 years, 4 months ago (2014-08-11 14:07:25 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:41:05 UTC) #11
Message was sent while issue was closed.
Change committed as 179956

Powered by Google App Engine
This is Rietveld 408576698