Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 431273003: Revert of Always notify the MediaPlayer of any seek. (Closed)

Created:
6 years, 4 months ago by alancutter (OOO until 2018)
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Always notify the MediaPlayer of any seek. (https://codereview.chromium.org/431903003/) Reason for revert: Test now flakily crashing on all platforms after this change: http/tests/media/media-source/mediasource-duration.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fmediasource-duration.html Example build: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/34873 BUG=399523 Original issue's description: > Always notify the MediaPlayer of any seek. > > This change removes short circuit logic for seeking to the current position. > There are certain situations, like seeking to a truncated duration, where the > HTMLMediaElement is not in the best position to determine whether a call to > the MediaPlayer is necessary or not. This change allows the > MediaPlayer/WebMediaPlayer implementation to determine what the best course > of action should be. This also makes the seeking behavior more spec > compliant because even a seek to the current position should have the > seeking attribute be true until a stable state occurs. This is guaranteed > when calling into the MediaPlayer and allows all seeks to be treated the > same at the HTMLMediaElement level. > > BUG=266631 > TEST=LayoutTests/media/video-seek-to-current-position.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179347 TBR=acolwell@chromium.org,philipj@opera.com,srirama.m@samsung.com NOTREECHECKS=true NOTRY=true BUG=266631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -102 lines) Patch
M LayoutTests/media/media-controller-effective-playback-rate.html View 2 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/media/media-controller-effective-playback-rate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/media-controller-playbackrate.html View 2 chunks +6 lines, -13 lines 0 comments Download
M LayoutTests/media/media-controller-playbackrate-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/media/video-seek-to-current-position.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/media/video-seek-to-current-position-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alancutter (OOO until 2018)
Created Revert of Always notify the MediaPlayer of any seek.
6 years, 4 months ago (2014-08-01 05:57:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/431273003/1
6 years, 4 months ago (2014-08-01 05:58:15 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 05:58:48 UTC) #3
Message was sent while issue was closed.
Change committed as 179368

Powered by Google App Engine
This is Rietveld 408576698