Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 431273002: compositor_bindings: Stop overriding createSolidColorLayer(). (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, darin-cc_chromium.org, jam, jamesr
Project:
chromium
Visibility:
Public.

Description

compositor_bindings: Stop overriding createSolidColorLayer(). This functions is not called anymore in Blink and thus it has no effect here in Chromium. So no need to keep overriding it. This also deletes web_solid_color_layer_impl.* because it becomes unused with this change. BUG=None TEST=None R=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288125

Patch Set 1 #

Patch Set 2 : rm web_solid_color_layer_impl.* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M content/content_renderer.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/compositor_bindings/web_compositor_support_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/compositor_bindings/web_compositor_support_impl.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download
D content/renderer/compositor_bindings/web_solid_color_layer_impl.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
D content/renderer/compositor_bindings/web_solid_color_layer_impl.cc View 1 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
Blink side -> https://codereview.chromium.org/432263002
6 years, 4 months ago (2014-08-01 02:44:42 UTC) #1
tfarina
Do'h this should be Adrienne. Adrienne, could you approve this to me? Thank you,
6 years, 4 months ago (2014-08-05 14:16:53 UTC) #2
enne (OOO)
Should you also remove WebSolidColorLayerImpl?
6 years, 4 months ago (2014-08-05 20:48:18 UTC) #3
tfarina
On 2014/08/05 20:48:18, enne wrote: > Should you also remove WebSolidColorLayerImpl? Do you want that ...
6 years, 4 months ago (2014-08-06 02:38:40 UTC) #4
enne (OOO)
On 2014/08/06 at 02:38:40, tfarina wrote: > On 2014/08/05 20:48:18, enne wrote: > > Should ...
6 years, 4 months ago (2014-08-06 17:21:02 UTC) #5
tfarina
On 2014/08/06 17:21:02, enne wrote: > On 2014/08/06 at 02:38:40, tfarina wrote: > > On ...
6 years, 4 months ago (2014-08-06 17:28:17 UTC) #6
tfarina
Removed. ptal.
6 years, 4 months ago (2014-08-07 02:29:24 UTC) #7
enne (OOO)
lgtm
6 years, 4 months ago (2014-08-07 17:05:44 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-07 17:15:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/431273002/20001
6 years, 4 months ago (2014-08-07 17:18:04 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-07 18:14:55 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 19:54:44 UTC) #12
Message was sent while issue was closed.
Change committed as 288125

Powered by Google App Engine
This is Rietveld 408576698