Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 431243002: [Telemetry] Fix running certain benchmarks on user builds (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix running certain benchmarks on user builds showmap may not exist. For example, see the Moto E: http://chromegw/i/chromium.perf/builders/Android%20MotoE%20Perf/builds/494/steps/page_cycler.intl_hi_ru/logs/stdio This causes us to degrade gracefully and not output memory metrics. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
6 years, 4 months ago (2014-07-31 23:49:23 UTC) #1
dtu
lgtm
6 years, 4 months ago (2014-08-01 19:32:49 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-01 19:33:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/431243002/1
6 years, 4 months ago (2014-08-01 19:34:28 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 06:12:20 UTC) #5
Message was sent while issue was closed. 
Change committed as 287166

Powered by Google App Engine
This is Rietveld 408576698