Issue 431183002: Add placeholder for RWHVChildFrame::CreateBrowserAccessibilityManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431183002: Add placeholder for RWHVChildFrame::CreateBrowserAccessibilityManager. (Closed)

Created:
6 years, 4 months ago by dmazzoni

Modified:
6 years, 4 months ago

Reviewers:
jam, Will Harris

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add placeholder for RWHVChildFrame::CreateBrowserAccessibilityManager. This is to avoid a NOTREACHED in the RWHVBase implementation of that virtual function. Actually fixing it will come soon. BUG=368298, 398282 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287129

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	content/browser/frame_host/render_widget_host_view_child_frame.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/browser/frame_host/render_widget_host_view_child_frame.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/431183002/20001

6 years, 4 months ago (2014-08-01 17:41:54 UTC) #4

Message was sent while issue was closed.

Change committed as 287129