chrome/browser/ui/views/toolbar/toolbar_view.cc - Issue 431173002: Create ExtensionActionView class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 431173002: Create ExtensionActionView class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge conflict Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc

index 6b0e8117e1f36c3fe007dffe5dae5f4797de955f..cea1d5764e51dcaffdf58412d29584d9a8d1bccb 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc

@@ -332,7 +332,7 @@ void ToolbarView::ShowPageActionPopup(const extensions::Extension* extension) {

extension_manager->GetPageAction(*extension);

if (extension_action) {

location_bar_->GetPageActionView(extension_action)->image_view()->

- ExecuteAction(ExtensionPopup::SHOW);

+ view_controller()->ExecuteAction(ExtensionPopup::SHOW, false);

}