chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc - Issue 431173002: Create ExtensionActionView class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

Issue 431173002: Create ExtensionActionView class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge conflict Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

diff --git a/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc b/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

index f389ac2d8f48050480a5de327dc9edf655f71cb9..43bfe34129611ee6d890fbe4b6e088a0941a47a6 100644

--- a/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

+++ b/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc

@@ -42,7 +42,7 @@ ExtensionAction* BrowserActionTestUtil::GetExtensionAction(int index) {

void BrowserActionTestUtil::InspectPopup(int index) {

GetContainer(browser_)->GetBrowserActionViewAt(index)->button()->

- InspectPopup();

+ view_controller()->InspectPopup();

}

bool BrowserActionTestUtil::HasIcon(int index) {

@@ -58,7 +58,7 @@ gfx::Image BrowserActionTestUtil::GetIcon(int index) {

void BrowserActionTestUtil::Press(int index) {

GetContainer(browser_)->GetBrowserActionViewAt(index)->

- button()->ExecuteBrowserAction();

+ button()->view_controller()->ExecuteActionByUser();

}

std::string BrowserActionTestUtil::GetExtensionId(int index) {