Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 431163002: webrtc deps in remoting should be inside a webrtc condition (Closed)

Created:
6 years, 4 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

webrtc deps in remoting should be inside a webrtc condition If you try to build with enable_webrtc=0 and remoting=1, gyp will fail: libjingle.gyp:libpeerconnection#target' when processing remoting.gyp:remoting_host#target. This happens because the libpeerconnnection target is defined inside an enable_webrtc==1 condition. Therefore, these dependencies in remoting.gyp should be too. BUG=399413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M remoting/remoting_host.gypi View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@Sergey, aiguha: does this look OK?
6 years, 4 months ago (2014-07-31 20:19:35 UTC) #1
aiguha
LGTM You might have already seen this: modules.gyp:desktop_capture#target is not defined inside an enable_webrtc==1 condition ...
6 years, 4 months ago (2014-08-01 18:35:56 UTC) #2
garykac
lgtm
6 years, 4 months ago (2014-08-01 18:38:12 UTC) #3
Mostyn Bramley-Moore
On 2014/08/01 18:35:56, aiguha wrote: > LGTM > > You might have already seen this: ...
6 years, 4 months ago (2014-08-01 18:49:23 UTC) #4
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-01 18:49:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/431163002/1
6 years, 4 months ago (2014-08-01 18:50:50 UTC) #6
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-02 07:56:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/431163002/1
6 years, 4 months ago (2014-08-02 07:58:28 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 11:19:03 UTC) #9
Message was sent while issue was closed.
Change committed as 287193

Powered by Google App Engine
This is Rietveld 408576698