Remove failing DCHECKs in Blob code.

content/browser/fileapi/blob_url_request_job_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
@@ skipping 80 matching lines @@
     temp_file_modification_time1_ = file_info1.last_modified;
 
     temp_file2_ = temp_dir_.path().AppendASCII("BlobFile2.dat");
     ASSERT_EQ(static_cast<int>(arraysize(kTestFileData2) - 1),
               base::WriteFile(temp_file2_, kTestFileData2,
                                    arraysize(kTestFileData2) - 1));
     base::File::Info file_info2;
     base::GetFileInfo(temp_file2_, &file_info2);
     temp_file_modification_time2_ = file_info2.last_modified;
 
+    temp_empty_file_ = temp_dir_.path().AppendASCII("EmptyBlobFile.dat");
+    ASSERT_EQ(static_cast<int>(0),

[cmumford, 2014/07/31 18:44:43]

Why the static_cast? Isn't 0 an integer literal already?

[pwnall-personal, 2014/07/31 19:34:47]

Done.

+              base::WriteFile(temp_empty_file_, kTestFileData1, 0));

[cmumford, 2014/07/31 18:44:43]

Nit: This certainly works, but maybe CreateTemporaryFileInDir might be a bit
cleaner.

[pwnall-personal, 2014/07/31 19:34:47]

Done.

+    base::File::Info empty_file_info;
+    base::GetFileInfo(temp_empty_file_, &empty_file_info);
+    temp_empty_file_modification_time_ = empty_file_info.last_modified;
+
     url_request_job_factory_.SetProtocolHandler("blob",
                                                 new MockProtocolHandler(this));
     url_request_context_.set_job_factory(&url_request_job_factory_);
   }
 
   virtual void TearDown() {
   }
 
   void SetUpFileSystem() {
     // Prepare file system.
@@ skipping 13 matching lines @@
     const char kFilename1[] = "FileSystemFile1.dat";
     temp_file_system_file1_ = GetFileSystemURL(kFilename1);
     WriteFileSystemFile(kFilename1, kTestFileSystemFileData1,
                         arraysize(kTestFileSystemFileData1) - 1,
                         &temp_file_system_file_modification_time1_);
     const char kFilename2[] = "FileSystemFile2.dat";
     temp_file_system_file2_ = GetFileSystemURL(kFilename2);
     WriteFileSystemFile(kFilename2, kTestFileSystemFileData2,
                         arraysize(kTestFileSystemFileData2) - 1,
                         &temp_file_system_file_modification_time2_);
+    const char kEmptyFilename[] = "EmptyFileSystemFile.dat";
+    temp_empty_file_system_file_ = GetFileSystemURL(kEmptyFilename);
+    WriteFileSystemFile(kEmptyFilename, kTestFileSystemFileData1,
+                        0, &temp_empty_file_system_file_modification_time_);
   }
 
   GURL GetFileSystemURL(const std::string& filename) {
     return GURL(file_system_root_url_.spec() + filename);
   }
 
   void WriteFileSystemFile(const std::string& filename,
                            const char* buf, int buf_size,
                            base::Time* modification_time) {
     fileapi::FileSystemURL url =
@@ skipping 57 matching lines @@
 
   void BuildComplicatedData(std::string* expected_result) {
     blob_data_->AppendData(kTestData1 + 1, 2);
     blob_data_->AppendFile(temp_file1_, 2, 3, temp_file_modification_time1_);
     blob_data_->AppendFileSystemFile(temp_file_system_file1_, 3, 4,
                                      temp_file_system_file_modification_time1_);
     blob_data_->AppendData(kTestData2 + 4, 5);
     blob_data_->AppendFile(temp_file2_, 5, 6, temp_file_modification_time2_);
     blob_data_->AppendFileSystemFile(temp_file_system_file2_, 6, 7,
                                      temp_file_system_file_modification_time2_);
+    blob_data_->AppendFile(temp_empty_file_, 0, 0,
+                           temp_empty_file_modification_time_);
+    blob_data_->AppendFileSystemFile(
+        temp_empty_file_system_file_, 0, 0,
+        temp_empty_file_system_file_modification_time_);
     *expected_result = std::string(kTestData1 + 1, 2);
     *expected_result += std::string(kTestFileData1 + 2, 3);
     *expected_result += std::string(kTestFileSystemFileData1 + 3, 4);
     *expected_result += std::string(kTestData2 + 4, 5);
     *expected_result += std::string(kTestFileData2 + 5, 6);
     *expected_result += std::string(kTestFileSystemFileData2 + 6, 7);
   }
 
   // This only works if all the Blob items have a definite pre-computed length.
   // Otherwise, this will fail a CHECK.
   int64 GetTotalBlobLength() const {
     int64 total = 0;
     const std::vector<BlobData::Item>& items = blob_data_->items();
     for (std::vector<BlobData::Item>::const_iterator it = items.begin();
          it != items.end(); ++it) {
       int64 length = base::checked_cast<int64>(it->length());
       CHECK(length <= kint64max - total);
       total += length;
     }
     return total;
   }
 
  protected:
   base::ScopedTempDir temp_dir_;
+  base::FilePath temp_empty_file_;
   base::FilePath temp_file1_;
   base::FilePath temp_file2_;
+  base::Time temp_empty_file_modification_time_;
   base::Time temp_file_modification_time1_;
   base::Time temp_file_modification_time2_;
   GURL file_system_root_url_;
+  GURL temp_empty_file_system_file_;
   GURL temp_file_system_file1_;
   GURL temp_file_system_file2_;
+  base::Time temp_empty_file_system_file_modification_time_;
   base::Time temp_file_system_file_modification_time1_;
   base::Time temp_file_system_file_modification_time2_;
 
   base::MessageLoopForIO message_loop_;
   scoped_refptr<fileapi::FileSystemContext> file_system_context_;
   scoped_refptr<BlobData> blob_data_;
   net::URLRequestJobFactoryImpl url_request_job_factory_;
   net::URLRequestContext url_request_context_;
   MockURLRequestDelegate url_request_delegate_;
   scoped_ptr<net::URLRequest> request_;
@@ skipping 155 matching lines @@
   std::string content_type;
   EXPECT_TRUE(request_->response_headers()->GetMimeType(&content_type));
   EXPECT_EQ(kTestContentType, content_type);
   void* iter = NULL;
   std::string content_disposition;
   EXPECT_TRUE(request_->response_headers()->EnumerateHeader(
       &iter, "Content-Disposition", &content_disposition));
   EXPECT_EQ(kTestContentDisposition, content_disposition);
 }
 
+TEST_F(BlobURLRequestJobTest, TestGetEmptyDataRequest) {
+  TestSuccessNonrangeRequest("", 0);
+}
+
 }  // namespace content