Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 431103002: Add integration tests for window.orientation. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@screen_orientation_integration
Project:
chromium
Visibility:
Public.

Description

Add integration tests for window.orientation. It gives the opportunity to remove the flaky ScreenOrientationIntegrationTest.java BUG=None TBR=jdduke@chromium.org (for some reasons, the presubmit hook doesn't consider that I own that file...) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287332

Patch Set 1 #

Patch Set 2 : and remove the java file #

Patch Set 3 : rebase #

Messages

Total messages: 9 (0 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-07-31 16:26:24 UTC) #1
Michael van Ouwerkerk
lgtm
6 years, 4 months ago (2014-07-31 16:57:45 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-04 11:28:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/431103002/40001
6 years, 4 months ago (2014-08-04 11:29:43 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was unchecked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-04 12:20:35 UTC) #5
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-04 12:20:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/431103002/40001
6 years, 4 months ago (2014-08-04 12:20:52 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 13:33:57 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 14:07:45 UTC) #9
Message was sent while issue was closed.
Change committed as 287332

Powered by Google App Engine
This is Rietveld 408576698