Issue 431083005: Revert of Re-enable ScreenOrientationListenerTest.java and run locking on UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431083005: Revert of Re-enable ScreenOrientationListenerTest.java and run locking on UI thread. (Closed)

Created:
6 years, 4 months ago by Peter Beverloo

Modified:
6 years, 4 months ago

Reviewers:
jdduke (slow), mlamouri (slow - plz ping)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Re-enable ScreenOrientationListenerTest.java and run locking on UI thread. (https://codereview.chromium.org/434693002/) Reason for revert: This broke the following test on the contentshell_instrumentation_tests on the Android Tests (dbg): ScreenOrientationListenerTest.testConfigurationListenerFlipLandscape http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20567/steps/contentshell_instrumentation_tests/logs/stdio Original issue's description: > Re-enable ScreenOrientationListenerTest.java and run locking on UI thread. > > BUG=356483, 354553 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287112 TBR=jdduke@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=356483, 354553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287210

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -41 lines)			Patch
	M	content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java	View		7 chunks	+65 lines, -41 lines	0 comments	Download

Total messages: 3 (0 generated)

Peter Beverloo

Created Revert of Re-enable ScreenOrientationListenerTest.java and run locking on UI thread.

6 years, 4 months ago (2014-08-02 12:32:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/431083005/1

6 years, 4 months ago (2014-08-02 12:32:53 UTC) #2

Message was sent while issue was closed.

Change committed as 287210