Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: components/signin/core/browser/about_signin_internals.cc

Issue 431083003: Change new-avatar-menu to an enable-disable flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase - [Still Includes NewAvatarMenu by default] Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/signin/core/browser/about_signin_internals.h" 5 #include "components/signin/core/browser/about_signin_internals.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/hash.h" 9 #include "base/hash.h"
10 #include "base/i18n/time_formatting.h" 10 #include "base/i18n/time_formatting.h"
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 // A summary of signin related info first. 358 // A summary of signin related info first.
359 base::ListValue* basic_info = AddSection(signin_info, "Basic Information"); 359 base::ListValue* basic_info = AddSection(signin_info, "Basic Information");
360 const std::string signin_status_string = 360 const std::string signin_status_string =
361 untimed_signin_fields[USERNAME - UNTIMED_FIELDS_BEGIN].empty() 361 untimed_signin_fields[USERNAME - UNTIMED_FIELDS_BEGIN].empty()
362 ? "Not Signed In" 362 ? "Not Signed In"
363 : "Signed In"; 363 : "Signed In";
364 AddSectionEntry(basic_info, "Chrome Version", product_version); 364 AddSectionEntry(basic_info, "Chrome Version", product_version);
365 AddSectionEntry(basic_info, "Signin Status", signin_status_string); 365 AddSectionEntry(basic_info, "Signin Status", signin_status_string);
366 AddSectionEntry(basic_info, "Web Based Signin Enabled?", 366 AddSectionEntry(basic_info, "Web Based Signin Enabled?",
367 switches::IsEnableWebBasedSignin() == true ? "True" : "False"); 367 switches::IsEnableWebBasedSignin() == true ? "True" : "False");
368 AddSectionEntry(basic_info, "New Avatar Menu Enabled?",
369 switches::IsNewAvatarMenu() == true ? "True" : "False");
368 AddSectionEntry(basic_info, "New Profile Management Enabled?", 370 AddSectionEntry(basic_info, "New Profile Management Enabled?",
369 switches::IsNewProfileManagement() == true ? "True" : "False"); 371 switches::IsNewProfileManagement() == true ? "True" : "False");
370 AddSectionEntry(basic_info, "New Avatar Menu Enabled?",
371 switches::IsNewAvatarMenu() == true ? "True" : "False");
372 bool new_avatar_menu_flag =
373 CommandLine::ForCurrentProcess()->HasSwitch(switches::kNewAvatarMenu);
374 AddSectionEntry(basic_info, "New Avatar Menu Flag Set?",
375 new_avatar_menu_flag ? "True" : "False");
376 AddSectionEntry(basic_info, "Account Consistency Enabled?", 372 AddSectionEntry(basic_info, "Account Consistency Enabled?",
377 switches::IsEnableAccountConsistency() == true ? "True" : "False"); 373 switches::IsEnableAccountConsistency() == true ? "True" : "False");
378 374
379 // Only add username. SID and LSID have moved to tokens section. 375 // Only add username. SID and LSID have moved to tokens section.
380 const std::string field = 376 const std::string field =
381 SigninStatusFieldToLabel(static_cast<UntimedSigninStatusField>(USERNAME)); 377 SigninStatusFieldToLabel(static_cast<UntimedSigninStatusField>(USERNAME));
382 AddSectionEntry(basic_info, 378 AddSectionEntry(basic_info,
383 field, 379 field,
384 untimed_signin_fields[USERNAME - UNTIMED_FIELDS_BEGIN]); 380 untimed_signin_fields[USERNAME - UNTIMED_FIELDS_BEGIN]);
385 381
(...skipping 23 matching lines...) Expand all
409 std::sort(it->second.begin(), it->second.end(), TokenInfo::LessThan); 405 std::sort(it->second.begin(), it->second.end(), TokenInfo::LessThan);
410 const std::vector<TokenInfo*>& tokens = it->second; 406 const std::vector<TokenInfo*>& tokens = it->second;
411 for (size_t i = 0; i < tokens.size(); ++i) { 407 for (size_t i = 0; i < tokens.size(); ++i) {
412 base::DictionaryValue* token_info = tokens[i]->ToValue(); 408 base::DictionaryValue* token_info = tokens[i]->ToValue();
413 token_details->Append(token_info); 409 token_details->Append(token_info);
414 } 410 }
415 } 411 }
416 412
417 return signin_status.Pass(); 413 return signin_status.Pass();
418 } 414 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698