Linux: Do not unload the o3d plugin in the browser process. This is a tempora...

Linux: Do not unload the o3d plugin in the browser process. This is a temporary workaround for a shutdown crash.

BUG=25245
TEST=no crash on shutdown.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33052

[Lei Zhang, 2009-11-24 21:00:25]

This seems safe to me. I'd like to cherrypick this into the 249 branch to help
bring down the crash rate.

I would blacklist based on version numbers as well, but we don't seem to have
that info.

[piman, 2009-11-24 23:43:38]

LGTM
Just to confirm, that is fixed with your -znodelete patch to o3d right ? This is
just to avoid crashing on older versions of the plugin ?

[Lei Zhang, 2009-11-24 23:48:41]

On 2009/11/24 23:43:38, piman wrote:
> LGTM
> Just to confirm, that is fixed with your -znodelete patch to o3d right ? This
is
> just to avoid crashing on older versions of the plugin ?

Correct. We suspect this is one of the few remaining browser process crashers on
Linux.

[Evan Martin, 2009-11-24 23:50:19]

In fairness to o3d, there are other plugins that seem to have similar problems. 
I am (today even) currently working on the OOP plugin querying, but I am not as
clever as John at implementing these sorts of things.  :)

[piman, 2009-11-24 23:52:41]

On Tue, Nov 24, 2009 at 3:50 PM, <evan@chromium.org> wrote:

> In fairness to o3d, there are other plugins that seem to have similar
> problems.
> I am (today even) currently working on the OOP plugin querying, but I am
> not as
> clever as John at implementing these sorts of things.  :)


If other plugins have the same issue, should we simply turn on RTLD_NODELETE
when dlopen-ing from the browser process ?


>
> http://codereview.chromium.org/431039
>

[willchan_google.com, 2009-11-24 23:55:33]

Caveat: I haven't looked at this issue in months, so I might be
completely off base.
Back when I was looking at linux crashers, I noticed that this
happened to many plugins, not just o3d.  I believe that this patch
will help, but I am skeptical it will fix all (or even the majority)
of the crashes from unloading plugins.

On Tue, Nov 24, 2009 at 3:50 PM,  <evan@chromium.org> wrote:
> In fairness to o3d, there are other plugins that seem to have similar
> problems.
> I am (today even) currently working on the OOP plugin querying, but I am not
> as
> clever as John at implementing these sorts of things.  :)
>
> http://codereview.chromium.org/431039
>

[Lei Zhang, 2009-11-25 00:00:37]

On 2009/11/24 23:55:33, willchan_google.com wrote:
> Caveat: I haven't looked at this issue in months, so I might be
> completely off base.
> Back when I was looking at linux crashers, I noticed that this
> happened to many plugins, not just o3d.  I believe that this patch
> will help, but I am skeptical it will fix all (or even the majority)
> of the crashes from unloading plugins.

Will, isn't that the RTLD_DEEPBIND issue?

I have a Jaunty test box with lots of plugins installed via apt-get. Granted,
this is by no means a complete set of all Linux plugins, but I haven't seen any
others cause the same shutdown crash that we see with O3D.

[willchan_google.com, 2009-11-25 00:04:33]

On Tue, Nov 24, 2009 at 4:00 PM,  <thestig@chromium.org> wrote:
> On 2009/11/24 23:55:33, willchan_google.com wrote:
>>
>> Caveat: I haven't looked at this issue in months, so I might be
>> completely off base.
>> Back when I was looking at linux crashers, I noticed that this
>> happened to many plugins, not just o3d.  I believe that this patch
>> will help, but I am skeptical it will fix all (or even the majority)
>> of the crashes from unloading plugins.
>
> Will, isn't that the RTLD_DEEPBIND issue?

No.  See bug http://code.google.com/p/chromium/issues/detail?id=19045
which is duped against
http://code.google.com/p/chromium/issues/detail?id=17863 which is what
Evan's tackling now.

>
> I have a Jaunty test box with lots of plugins installed via apt-get.
> Granted,
> this is by no means a complete set of all Linux plugins, but I haven't seen
> any
> others cause the same shutdown crash that we see with O3D.
>
> http://codereview.chromium.org/431039
>

[Lei Zhang, 2009-11-25 04:59:43]

On 2009/11/25 00:00:37, Lei Zhang wrote:
> On 2009/11/24 23:55:33, http://willchan_google.com wrote:
> > Caveat: I haven't looked at this issue in months, so I might be
> > completely off base.
> > Back when I was looking at linux crashers, I noticed that this
> > happened to many plugins, not just o3d.  I believe that this patch
> > will help, but I am skeptical it will fix all (or even the majority)
> > of the crashes from unloading plugins.
> 
> Will, isn't that the RTLD_DEEPBIND issue?
> 
> I have a Jaunty test box with lots of plugins installed via apt-get. Granted,
> this is by no means a complete set of all Linux plugins, but I haven't seen
any
> others cause the same shutdown crash that we see with O3D.

I've installed every browser plugin possible via apt-get and all the proprietary
ones I know of for a total of 30. None of them cause the tls destructor crash.
So I'm just going to have to pick on o3d.

[Evan Martin, 2009-11-25 18:13:44]

On 2009/11/25 04:59:43, Lei Zhang wrote:
> I've installed every browser plugin possible via apt-get and all the
proprietary
> ones I know of for a total of 30. None of them cause the tls destructor crash.
> So I'm just going to have to pick on o3d.

Haha, awesome.  How long does about:plugins take to load on a fresh start? ;)