Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 431023003: Remove deprecated extension notifications from ApiResourceManager (Closed)

Created:
6 years, 4 months ago by limasdf
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Cook
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated extension notifications from ApiResourceManager. And Move api_resource_manager_unittest.cc to extensions_unittests to pass the unittest.(by using ExtensionsTest) BUG=397164, 354046 TEST=extensions_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287485

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -27 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/api_resource_manager.h View 5 chunks +21 lines, -18 lines 0 comments Download
M extensions/browser/api/api_resource_manager_unittest.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
limasdf
PTAL. Lei, for /chrome Yoyo, for /extensions CC James, just want to let you know ...
6 years, 4 months ago (2014-08-02 16:20:14 UTC) #1
Lei Zhang
chrome/chrome_tests_unit.gypi lgtm
6 years, 4 months ago (2014-08-02 16:49:05 UTC) #2
Yoyo Zhou
LGTM
6 years, 4 months ago (2014-08-04 19:01:53 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 4 months ago (2014-08-05 00:10:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/431023003/40001
6 years, 4 months ago (2014-08-05 00:13:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 04:10:24 UTC) #6
limasdf
The CQ bit was unchecked by limasdf@gmail.com
6 years, 4 months ago (2014-08-05 04:11:25 UTC) #7
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 4 months ago (2014-08-05 04:51:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/431023003/40001
6 years, 4 months ago (2014-08-05 04:52:39 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 06:50:46 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 07:53:41 UTC) #11
Message was sent while issue was closed.
Change committed as 287485

Powered by Google App Engine
This is Rietveld 408576698