Issue 431003002: Add comment with svn revision number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431003002: Add comment with svn revision number. (Closed)

Created:
6 years, 4 months ago by szager1

Modified:
6 years, 4 months ago

Reviewers:
Mark Mentovai, iannucci, hinoka

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Add comment with svn revision number. R=iannucci@chromium.org,hinoka@chromium.org,mark@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287057

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -18 lines)			Patch
	M	roll_dep.py	View	1 2 3	8 chunks	+53 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/431003002/diff/40001/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/431003002/diff/40001/roll_dep.py#newcode262 roll_dep.py:262: deps_lines[line_idx] = '%s # %s' % (content.rstrip(), comment) ...

6 years, 4 months ago (2014-08-01 18:43:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/431003002/60001

6 years, 4 months ago (2014-08-01 18:51:32 UTC) #4

iannucci

6 years, 4 months ago (2014-08-01 19:40:21 UTC) #6

Message was sent while issue was closed.

retro-lgtm.

would be nice to have a before/after example in the CL description / message,
but oh well.

Expand Messages | Collapse Messages

Issue 431003002: Add comment with svn revision number. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages