third_party/zlib/google/zip_internal.cc - Issue 430963002: gn win: Fix potentially uninitialized variable warning in zip_internal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/zlib/google/zip_internal.cc

Issue 430963002: gn win: Fix potentially uninitialized variable warning in zip_internal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/zlib/google/zip_internal.cc

diff --git a/third_party/zlib/google/zip_internal.cc b/third_party/zlib/google/zip_internal.cc

index 6349b7a5e8c6b35d5dfab6ade16e00d6f9d994cc..3150266a96c7a8a13181f133fadb7923e09ec25d 100644

--- a/third_party/zlib/google/zip_internal.cc

+++ b/third_party/zlib/google/zip_internal.cc

@@ -42,7 +42,7 @@ void* ZipOpenFunc(void *opaque, const char* filename, int mode) {

HANDLE file = 0;

void* ret = NULL;

- desired_access = share_mode = flags_and_attributes = 0;

+ desired_access = creation_disposition = share_mode = flags_and_attributes = 0;

if ((mode & ZLIB_FILEFUNC_MODE_READWRITEFILTER) == ZLIB_FILEFUNC_MODE_READ) {

desired_access = GENERIC_READ;

« no previous file with comments | « no previous file | no next file » | no next file with comments »