Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: ppapi/tests/test_media_stream_audio_track.cc

Issue 430943004: Return from |Configure()| asynchronously, and allow |InitBuffers()| to return errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pepper-mediastream-duration
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/tests/test_media_stream_audio_track.cc
diff --git a/ppapi/tests/test_media_stream_audio_track.cc b/ppapi/tests/test_media_stream_audio_track.cc
index 05cb0bf3ad7e3c013c1af185ca2fd1c62e812d8e..efbe24ffe776310483d914c66e36ebac07cb4b35 100644
--- a/ppapi/tests/test_media_stream_audio_track.cc
+++ b/ppapi/tests/test_media_stream_audio_track.cc
@@ -204,6 +204,14 @@ std::string TestMediaStreamAudioTrack::TestConfigure() {
ASSERT_FALSE(audio_track_.HasEnded());
ASSERT_FALSE(audio_track_.GetId().empty());
+ // Do nothing.
teravest 2014/07/31 20:54:55 What's this comment for?
Anand Mistry (off Chromium) 2014/07/31 23:54:48 Expanded.
+ {
+ int32_t attrib_list[] = {
+ PP_MEDIASTREAMAUDIOTRACK_ATTRIB_NONE,
+ };
+ ASSERT_SUBTEST_SUCCESS(CheckConfigure(attrib_list, PP_OK));
+ }
+
// Configure number of buffers.
struct {
int32_t buffers;

Powered by Google App Engine
This is Rietveld 408576698