Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 430933004: Mark json results failures as unexpected in python tests. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, telemetry+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mark json results failures as unexpected in python tests. If we don't mark the failures as unexpected, the result-reading logic on the bots views the failures as expected and hence ignores them, leading us to let bad changes through :(. TBR=ojan@chromium.org, viettrungluu@chromium.org, tonyg@chromium.org, grt@chromium.org BUG=264859, 323212, 398027 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286761

Patch Set 1 #

Patch Set 2 : fix copy/paste into mini_installer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M chrome/test/mini_installer/test_installer.py View 1 1 chunk +7 lines, -4 lines 0 comments Download
M mojo/tools/run_mojo_python_tests.py View 1 chunk +7 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/unittest/json_results.py View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-07-31 00:31:13 UTC) #1
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-07-31 00:31:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/430933004/20001
6 years, 4 months ago (2014-07-31 00:33:47 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 00:33:48 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-31 00:33:49 UTC) #5
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-07-31 00:38:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/430933004/20001
6 years, 4 months ago (2014-07-31 00:39:45 UTC) #7
ojan
lgtm
6 years, 4 months ago (2014-07-31 00:53:45 UTC) #8
grt (UTC plus 2)
lgtm
6 years, 4 months ago (2014-07-31 01:03:12 UTC) #9
viettrungluu
lgtm
6 years, 4 months ago (2014-07-31 01:34:14 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 12:28:26 UTC) #11
Message was sent while issue was closed.
Change committed as 286761

Powered by Google App Engine
This is Rietveld 408576698