Use tighter typing in editing: PlainTextRange / ReplaceNodeWithSpanCommand

Use tighter typing in editing: PlainTextRange / ReplaceNodeWithSpanCommand

Use tighter typing in editing/ to increase code readability. This CL focuses on
PlainTextRange / ReplaceNodeWithSpanCommand.

R=leviw@chromium.org, adamk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179318

[adamk, 2014-07-30 19:50:35]

lgtm

[Inactive, 2014-07-31 14:06:47]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-31 14:07:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/430843002/20001

[commit-bot: I haz the power, 2014-07-31 14:07:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 14:07:54]

Failed to apply patch for Source/core/editing/RemoveFormatCommand.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/RemoveFormatCommand.cpp
  Hunk #1 FAILED at 87.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/editing/RemoveFormatCommand.cpp.rej

Patch:       Source/core/editing/RemoveFormatCommand.cpp
Index: Source/core/editing/RemoveFormatCommand.cpp
diff --git a/Source/core/editing/RemoveFormatCommand.cpp
b/Source/core/editing/RemoveFormatCommand.cpp
index
ee8696d606ac7d486b16f2513251576e4b74a799..20bf63161f2f9d8b6e279fe9c63ddbe287cb9e8d
100644
--- a/Source/core/editing/RemoveFormatCommand.cpp
+++ b/Source/core/editing/RemoveFormatCommand.cpp
@@ -87,7 +87,7 @@ void RemoveFormatCommand::doApply()
 
     // Get the default style for this editable root, it's the style that we'll
give the
     // content that we're operating on.
-    Node* root = frame->selection().rootEditableElement();
+    Element* root = frame->selection().rootEditableElement();
     RefPtrWillBeRawPtr<EditingStyle> defaultStyle = EditingStyle::create(root);
 
     // We want to remove everything but transparent background.

[Inactive, 2014-07-31 14:16:44]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-31 14:17:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/430843002/40001

[commit-bot: I haz the power, 2014-07-31 15:31:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-07-31 15:55:52]

Change committed as 179318