Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 430823002: Drop editing's createFullMarkup() function (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Drop editing's createFullMarkup() function Drop editing's createFullMarkup() function and inline it into the caller instead. There is only one caller and that caller passes a Document to the function so the function ends up doing a simple call to createMarkup(node). R=adamk@chromium.org, leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179244

Patch Set 1 #

Total comments: 3

Patch Set 2 : Omit optional arguments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M Source/core/editing/markup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 4 months ago (2014-07-30 16:57:29 UTC) #1
adamk
https://codereview.chromium.org/430823002/diff/1/Source/web/WebLocalFrameImpl.cpp File Source/web/WebLocalFrameImpl.cpp (right): https://codereview.chromium.org/430823002/diff/1/Source/web/WebLocalFrameImpl.cpp#newcode1466 Source/web/WebLocalFrameImpl.cpp:1466: return createMarkup(frame()->document(), IncludeNode, 0); Why do you need the ...
6 years, 4 months ago (2014-07-30 17:16:18 UTC) #2
Inactive
https://codereview.chromium.org/430823002/diff/1/Source/web/WebLocalFrameImpl.cpp File Source/web/WebLocalFrameImpl.cpp (right): https://codereview.chromium.org/430823002/diff/1/Source/web/WebLocalFrameImpl.cpp#newcode1466 Source/web/WebLocalFrameImpl.cpp:1466: return createMarkup(frame()->document(), IncludeNode, 0); On 2014/07/30 17:16:18, adamk wrote: ...
6 years, 4 months ago (2014-07-30 17:22:30 UTC) #3
Inactive
https://codereview.chromium.org/430823002/diff/1/Source/web/WebLocalFrameImpl.cpp File Source/web/WebLocalFrameImpl.cpp (right): https://codereview.chromium.org/430823002/diff/1/Source/web/WebLocalFrameImpl.cpp#newcode1466 Source/web/WebLocalFrameImpl.cpp:1466: return createMarkup(frame()->document(), IncludeNode, 0); On 2014/07/30 17:16:18, adamk wrote: ...
6 years, 4 months ago (2014-07-30 17:25:10 UTC) #4
adamk
lgtm
6 years, 4 months ago (2014-07-30 17:30:24 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-30 17:31:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/430823002/20001
6 years, 4 months ago (2014-07-30 17:31:46 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 18:33:02 UTC) #8
Message was sent while issue was closed.
Change committed as 179244

Powered by Google App Engine
This is Rietveld 408576698