chrome/browser/notifications/desktop_notification_service.h - Issue 430813004: Componentize content_settings_provider.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.h

Issue 430813004: Componentize content_settings_provider.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/desktop_notification_service.h

diff --git a/chrome/browser/notifications/desktop_notification_service.h b/chrome/browser/notifications/desktop_notification_service.h

index cdb59729167edaf2429f8abc1772f8a09c79bbbf..abd5525c9c084559c66f67f11d39a567417f8ad6 100644

--- a/chrome/browser/notifications/desktop_notification_service.h

+++ b/chrome/browser/notifications/desktop_notification_service.h

@@ -17,10 +17,10 @@

#include "base/prefs/pref_member.h"

#include "base/scoped_observer.h"

#include "base/strings/string16.h"

-#include "chrome/browser/content_settings/content_settings_provider.h"

#include "chrome/browser/content_settings/permission_context_base.h"

#include "chrome/browser/notifications/extension_welcome_notification.h"

#include "chrome/common/content_settings.h"

+#include "components/content_settings/core/browser/content_settings_provider.h"

vabr (Chromium) 2014/08/01 11:58:04 It does not look needed at all, could you remove i

lucinka.brozkova 2014/08/01 13:25:08 Removed, but added to chrome_content_browser_clien

#include "components/keyed_service/core/keyed_service.h"

#include "extensions/browser/extension_registry_observer.h"

#include "third_party/WebKit/public/platform/WebNotificationPermission.h"