components/content_settings.gypi - Issue 430813004: Componentize content_settings_provider.h

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/content_settings.gypi

Issue 430813004: Componentize content_settings_provider.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'targets': [	6 'targets': [

7 {	7 {

8 # GN version: //components/content_settings/core/common	8 # GN version: //components/content_settings/core/common

9 'target_name': 'content_settings_core_common',	9 'target_name': 'content_settings_core_common',

10 'type': 'none',	10 'type': 'none',

11 'include_dirs': [	11 'include_dirs': [

12 '..',	12 '..',

13 ],	13 ],

14 'sources': [	14 'sources': [

15 # Note: sources list duplicated in GN build.	15 # Note: sources list duplicated in GN build.

16 'content_settings/core/common/content_settings_types.h',	16 'content_settings/core/common/content_settings_types.h',

	17 'content_settings/core/browser/content_settings_provider.h',
	vabr (Chromium) 2014/08/01 11:58:04 You need to create a new target (content_settings_ You need to create a new target (content_settings_core_browser), and put it in there. lucinka.brozkova 2014/08/01 13:25:09 Done. Show quoted text On 2014/08/01 11:58:04, vabr (Chromium) wrote: > You need to create a new target (content_settings_core_browser), and put it in > there. Done.
17 ],	18 ],

18 },	19 },

19 ],	20 ],

20 }	21 }

OLD	NEW