Resolve registry root paths in HandleCloser

Resolve registry root paths in HandleCloser

BUG=349162
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289764

[jschuh, 2014-08-12 05:56:02]

I need to land some improved tests in a follow-up, but I'd like to get this in.

[cpu_(ooo_6.6-7.5), 2014-08-13 23:18:36]

https://codereview.chromium.org/430753002/diff/20001/sandbox/win/src/handle_c...
File sandbox/win/src/handle_closer.cc (right):

https://codereview.chromium.org/430753002/diff/20001/sandbox/win/src/handle_c...
sandbox/win/src/handle_closer.cc:45: if (handle_type == base::string16(L"Key"))
can you use == L"key"; so avoids constructing a string object in the hopes that
there is an std::string::operator=(const wchar_t*) ?

else

lgtm

Are there tests for ResolveRegistryName? if not we should add one.

[jschuh, 2014-08-14 20:13:04]

On 2014/08/13 23:18:36, cpu (slow to respond) wrote:
>
https://codereview.chromium.org/430753002/diff/20001/sandbox/win/src/handle_c...
> File sandbox/win/src/handle_closer.cc (right):
> 
>
https://codereview.chromium.org/430753002/diff/20001/sandbox/win/src/handle_c...
> sandbox/win/src/handle_closer.cc:45: if (handle_type ==
base::string16(L"Key"))
> can you use == L"key"; so avoids constructing a string object in the hopes
that
> there is an std::string::operator=(const wchar_t*) ?

Yeah, won't compile due to multiple possible promotions.

> else
> 
> lgtm
> 
> Are there tests for ResolveRegistryName? if not we should add one.

Not direct tests. It's covered pretty well in the registry policy tests, but I
can add in a unit test when I clean up the tests all around.

[jschuh, 2014-08-14 20:13:07]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2014-08-14 20:15:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jschuh@chromium.org/430753002/20001

[commit-bot: I haz the power, 2014-08-15 03:20:35]

Committed patchset #1 (20001) as 289764