Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 430733002: [webcrypto] Remove the MAYBE() test macro (Closed)

Created:
6 years, 4 months ago by eroman
Modified:
6 years, 4 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Remove the MAYBE() test macro Now that all of the tests run on both BoringSSL and NSS, there is no need for the MAYBE() macro. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287301

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove all other tests #

Patch Set 3 : rebase #

Patch Set 4 : Fix bad rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
eroman
(There are 3 CL which have to land sequentially before this one can) https://codereview.chromium.org/430733002/diff/1/content/child/webcrypto/shared_crypto_unittest.cc File ...
6 years, 4 months ago (2014-07-30 04:27:12 UTC) #1
eroman
Actually I am going to re-work this CL: * Will TBR a CL which enables ...
6 years, 4 months ago (2014-07-30 15:57:16 UTC) #2
eroman
ready for review again now.
6 years, 4 months ago (2014-07-30 18:13:36 UTC) #3
Ryan Sleevi
lgtm
6 years, 4 months ago (2014-07-30 18:16:31 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 4 months ago (2014-08-03 16:27:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/430733002/40001
6 years, 4 months ago (2014-08-03 16:28:33 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-03 17:12:19 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-03 17:16:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/2373)
6 years, 4 months ago (2014-08-03 17:16:03 UTC) #9
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 4 months ago (2014-08-04 04:03:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/430733002/60001
6 years, 4 months ago (2014-08-04 04:04:17 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-04 06:00:56 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 08:03:21 UTC) #13
Message was sent while issue was closed.
Change committed as 287301

Powered by Google App Engine
This is Rietveld 408576698