Issue 430693003: yield* calls @@iterator on iterable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430693003: yield* calls @@iterator on iterable (Closed)

Created:
6 years, 4 months ago by wingo

Modified:
6 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

yield* calls @@iterator on iterable R=rossberg@chromium.org BUG=v8:3422 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=22872

Patch Set 2 : Removed extra flag from test #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -20 lines)			Patch
M	src/parser.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/parser.cc	View		2 chunks	+16 lines, -17 lines	0 comments	Download
M	src/preparser.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/generators-iteration.js	View	1	3 chunks	+33 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://codereview.chromium.org/430693003/diff/1/test/mjsunit/harmony/generators-iteration.js File test/mjsunit/harmony/generators-iteration.js (right): https://codereview.chromium.org/430693003/diff/1/test/mjsunit/harmony/generators-iteration.js#newcode28 test/mjsunit/harmony/generators-iteration.js:28: // Flags: --harmony-generators --expose-gc --harmony-symbols Note: --harmony-symbols should ...

6 years, 4 months ago (2014-08-05 11:58:02 UTC) #2

wingo

6 years, 4 months ago (2014-08-05 13:17:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 22872 (presubmit successful).

Expand Messages | Collapse Messages

Issue 430693003: yield* calls @@iterator on iterable (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removed extra flag from test #

Messages