Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 430673002: Rename ServerBoundCert => ChannelID to reflect the current name. (Closed)

Created:
6 years, 4 months ago by wtc
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, ozone-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename ServerBoundCert => ChannelID to reflect the current name. These were missed by the big renaming CL https://codereview.chromium.org/356713005/. R=rch@chromium.org,asargent@chromium.org,lcwu@chromium.org TBR=twilson@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287932

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M chrome/browser/extensions/api/socket/tls_socket_unittest.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chromecast/shell/browser/url_request_context_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/shell/browser/url_request_context_factory.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M components/policy/core/common/cloud/system_policy_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
wtc
rch: please review everything. asargent: please review chrome/browser/extensions. lcwu: please review chromecast. twilson: please review ...
6 years, 4 months ago (2014-07-30 01:05:59 UTC) #1
lcwu1
LGTM on chromecast.
6 years, 4 months ago (2014-07-30 01:35:13 UTC) #2
Ryan Hamilton
lgtm Thanks for catching this Wan-Teh. I thought I got them all but I clearly ...
6 years, 4 months ago (2014-07-30 02:59:17 UTC) #3
asargent_no_longer_on_chrome
c/b/e lgtm
6 years, 4 months ago (2014-07-30 19:55:45 UTC) #4
lcwu1
Hi Wan-Teh, Are you going to submit this CL soon (as cast_shell is currently broken ...
6 years, 4 months ago (2014-08-06 18:22:58 UTC) #5
wtc
This CL is still missing an OWNER's review for components/policy. Since the change in that ...
6 years, 4 months ago (2014-08-06 18:44:29 UTC) #6
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 4 months ago (2014-08-06 18:44:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/430673002/1
6 years, 4 months ago (2014-08-06 18:46:38 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-06 19:21:14 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 19:22:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/2145)
6 years, 4 months ago (2014-08-06 19:22:28 UTC) #11
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 4 months ago (2014-08-06 21:26:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/430673002/20001
6 years, 4 months ago (2014-08-06 21:28:25 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 02:28:45 UTC) #14
Message was sent while issue was closed.
Change committed as 287932

Powered by Google App Engine
This is Rietveld 408576698