components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h - Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing bengr comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

index ca913c62df380d0bcae3c20a6545f9bc3102dc1a..ff422c12d1e7380094f02ad8e933e7f8b5066cdc 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

@@ -34,6 +34,8 @@ class DataReductionProxyAuthRequestHandler {

// Constructs an authentication request handler.

explicit DataReductionProxyAuthRequestHandler(

+ const std::string& client,

+ const std::string& version,

DataReductionProxyParams* params);

virtual ~DataReductionProxyAuthRequestHandler();

@@ -52,9 +54,7 @@ class DataReductionProxyAuthRequestHandler {

// authentication protocol version that the client uses, which should be

// |kProtocolVersion| unless the client expects to be handled differently from

// the standard behavior.

- void SetKey(const std::string& key,

- const std::string& client,

- const std::string& version);

+ void SetKey(const std::string& key);

protected:

void Init();