chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h - Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing bengr comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

index f75f20dfdcb93634e5b0670678a8db05eb202132..ab9b147daf4e9a1d4827ab6ae37c9bffc07f45f4 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

@@ -32,6 +32,14 @@ class DataReductionProxyChromeSettings

// get the appropriate pref service.

virtual void InitDataReductionProxySettings(Profile* profile);

+ // Using the chrome::VersionInfo version, returns the build and patch portion

+ // of the string delimited by a period. If the chrome::VersionInfo version

+ // isn't of the form xx.xx.xx.xx returns an empty string.

+ static std::string GetBuildAndPatchNumber();

+ // Gets the client type for the data reduction proxy.

+ static std::string GetClient();

private:

DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings);

};