Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing bengr comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
index 6130eda1b94f3017ca29bfdb067696a723d74a41..7ca11365f84a5abd09a138243499adf23a38548d 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
@@ -20,9 +20,6 @@
namespace data_reduction_proxy {
-// The version of the authentication protocol.
-const char kProtocolVersion[] = "0";
-
// The clients supported by the data reduction proxy.
const char kClientAndroidWebview[] = "webview";
const char kClientChromeAndroid[] = "android";
@@ -36,9 +33,9 @@ bool DataReductionProxyAuthRequestHandler::IsKeySetOnCommandLine() {
}
DataReductionProxyAuthRequestHandler::DataReductionProxyAuthRequestHandler(
- DataReductionProxyParams* params)
+ DataReductionProxyParams* params, const std::string& version)
bengr 2014/07/31 18:22:40 This won't work with android webview. Also, I don
megjablon 2014/07/31 20:48:36 Done.
: data_reduction_proxy_params_(params) {
- version_ = kProtocolVersion;
+ version_ = version;
#if defined(OS_ANDROID)
client_ = kClientChromeAndroid;
#elif defined(OS_IOS)

Powered by Google App Engine
This is Rietveld 408576698