chrome/browser/io_thread.cc - Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/io_thread.cc

Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing comment format Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/io_thread.cc

diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc

index 3c632ee8ffd0fbff66c94a8cc2faad4afcc988fe..fad09be743159721f4f58fb19dd7d794bfe81c22 100644

--- a/chrome/browser/io_thread.cc

+++ b/chrome/browser/io_thread.cc

@@ -651,8 +651,10 @@ void IOThread::InitAsync() {

DataReductionProxyParams* proxy_params =

new DataReductionProxyParams(drp_flags);

globals_->data_reduction_proxy_params.reset(proxy_params);

+ chrome::VersionInfo version_info;

globals_->data_reduction_proxy_auth_request_handler.reset(

- new DataReductionProxyAuthRequestHandler(proxy_params));

+ new DataReductionProxyAuthRequestHandler(

+ proxy_params, version_info.Version()));

bengr 2014/07/30 00:16:47 I would pass just the build and patch here. The au

megjablon 2014/07/30 20:37:17 Done.

globals_->on_resolve_proxy_handler =

ChromeNetworkDelegate::OnResolveProxyHandler(

base::Bind(data_reduction_proxy::OnResolveProxyHandler));