Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing Lei comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
index ca913c62df380d0bcae3c20a6545f9bc3102dc1a..3af906cbd1c4f41ea9a9e05b95d5af353fb468f2 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
@@ -20,7 +20,7 @@ class URLRequest;
namespace data_reduction_proxy {
-extern const char kProtocolVersion[];
+extern const char kAndroidWebViewProtocolVersion[];
extern const char kClientAndroidWebview[];
extern const char kClientChromeAndroid[];
@@ -32,8 +32,14 @@ class DataReductionProxyAuthRequestHandler {
public:
static bool IsKeySetOnCommandLine();
- // Constructs an authentication request handler.
- explicit DataReductionProxyAuthRequestHandler(
+ // Constructs an authentication request handler. Client is the canonical name
+ // for the client. Client names should be defined in this file as one of
+ // |kClient...|. Version is the authentication protocol version that the
+ // client uses, which should be |kProtocolVersion| unless the client expects
+ // to be handled differently from the standard behavior.
+ DataReductionProxyAuthRequestHandler(
+ const std::string& client,
+ const std::string& version,
DataReductionProxyParams* params);
virtual ~DataReductionProxyAuthRequestHandler();
@@ -47,14 +53,8 @@ class DataReductionProxyAuthRequestHandler {
// Sets a new authentication key. This must be called for platforms that do
// not have a default key defined. See the constructor implementation for
- // those platforms. Client is the canonical name for the client. Client names
- // should be defined in this file as one of |kClient...|. Version is the
- // authentication protocol version that the client uses, which should be
- // |kProtocolVersion| unless the client expects to be handled differently from
- // the standard behavior.
- void SetKey(const std::string& key,
- const std::string& client,
- const std::string& version);
+ // those platforms.
+ void SetKey(const std::string& key);
protected:
void Init();

Powered by Google App Engine
This is Rietveld 408576698