Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

Issue 430643002: Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing bengr comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
index ca913c62df380d0bcae3c20a6545f9bc3102dc1a..ff422c12d1e7380094f02ad8e933e7f8b5066cdc 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
@@ -34,6 +34,8 @@ class DataReductionProxyAuthRequestHandler {
// Constructs an authentication request handler.
explicit DataReductionProxyAuthRequestHandler(
Lei Zhang 2014/08/01 19:11:57 nit: no longer explicit.
megjablon 2014/08/01 20:35:26 Done.
+ const std::string& client,
+ const std::string& version,
DataReductionProxyParams* params);
virtual ~DataReductionProxyAuthRequestHandler();
@@ -52,9 +54,7 @@ class DataReductionProxyAuthRequestHandler {
// authentication protocol version that the client uses, which should be
// |kProtocolVersion| unless the client expects to be handled differently from
// the standard behavior.
- void SetKey(const std::string& key,
- const std::string& client,
- const std::string& version);
+ void SetKey(const std::string& key);
protected:
void Init();

Powered by Google App Engine
This is Rietveld 408576698