Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
430643002:
Correcting the version field in the Chrome-Proxy header to be the chromium build and patch number. (Closed)
DescriptionThe data reduction proxy client should be specific about it's capabilities by specifying the version of the proxy client that is being used.
A version field is now added to the Chrome-Proxy header in requests, but that version is set to zero.
This corrects the version field in the Chrome-Proxy header to be the chromium build and patch number.
BUG=367268
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287970
Patch Set 1 #Patch Set 2 : Fixing comment format #
Total comments: 6
Patch Set 3 : Addressing bengr comments #
Total comments: 6
Patch Set 4 : Addressing bengr comments #
Total comments: 2
Patch Set 5 : Addressing bengr comments #
Total comments: 12
Patch Set 6 : Addressing Lei comments #
Total comments: 2
Patch Set 7 : Addressing Lei comments #
Total comments: 2
Patch Set 8 : Rebase master #Patch Set 9 : Trybot test fix #Messages
Total messages: 39 (0 generated)
thestig: io_thread.cc bengr: components/*
https://codereview.chromium.org/430643002/diff/20001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/430643002/diff/20001/chrome/browser/io_thread... chrome/browser/io_thread.cc:657: proxy_params, version_info.Version())); I would pass just the build and patch here. The auth request handler shouldn't know anything about the format of the version. https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:40: version_ = version.substr(version.find(".")).substr(version.find(".") + 1); Use SplitString. See: https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin... Put it in a utility function here that can be used by embedders. Add a test for the function. https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h (right): https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:35: DataReductionProxyParams* params, std::string version); This should be const std::string& version and on its own line.
https://codereview.chromium.org/430643002/diff/20001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/430643002/diff/20001/chrome/browser/io_thread... chrome/browser/io_thread.cc:657: proxy_params, version_info.Version())); On 2014/07/30 00:16:47, bengr1 wrote: > I would pass just the build and patch here. The auth request handler shouldn't > know anything about the format of the version. Done. https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:40: version_ = version.substr(version.find(".")).substr(version.find(".") + 1); On 2014/07/30 00:16:47, bengr1 wrote: > Use SplitString. See: > https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin... > > > Put it in a utility function here that can be used by embedders. Add a test for > the function. Done. https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h (right): https://codereview.chromium.org/430643002/diff/20001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:35: DataReductionProxyParams* params, std::string version); On 2014/07/30 00:16:47, bengr1 wrote: > This should be const std::string& version and on its own line. Done.
https://codereview.chromium.org/430643002/diff/40001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/430643002/diff/40001/chrome/browser/io_thread... chrome/browser/io_thread.cc:655: chrome::VersionInfo version_info; This is an implementation detail, so put it inside GetBuildAndPatchNumber. https://codereview.chromium.org/430643002/diff/40001/chrome/browser/net/spdyp... File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc (right): https://codereview.chromium.org/430643002/diff/40001/chrome/browser/net/spdyp... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:47: base::SplitString(version, '.', &version_parts); You should check that the vector size is 4. Optional: for symmetry, you could erase the first two elements and then call JoinString https://codereview.chromium.org/430643002/diff/40001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/40001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:36: DataReductionProxyParams* params, const std::string& version) This won't work with android webview. Also, I don't like the interface. I think a better interface is: DataReductionProxyAuthRequestHandler( const std::string& client, const std::string& version, DataReductionProxyParams* params); void SetKey(const std::string& key);
https://codereview.chromium.org/430643002/diff/40001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/430643002/diff/40001/chrome/browser/io_thread... chrome/browser/io_thread.cc:655: chrome::VersionInfo version_info; On 2014/07/31 18:22:40, bengr1 wrote: > This is an implementation detail, so put it inside GetBuildAndPatchNumber. Done. https://codereview.chromium.org/430643002/diff/40001/chrome/browser/net/spdyp... File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc (right): https://codereview.chromium.org/430643002/diff/40001/chrome/browser/net/spdyp... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:47: base::SplitString(version, '.', &version_parts); On 2014/07/31 18:22:40, bengr1 wrote: > You should check that the vector size is 4. > Optional: for symmetry, you could erase the first two elements and then call > JoinString Done. https://codereview.chromium.org/430643002/diff/40001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/40001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:36: DataReductionProxyParams* params, const std::string& version) On 2014/07/31 18:22:40, bengr1 wrote: > This won't work with android webview. > > Also, I don't like the interface. I think a better interface is: > > DataReductionProxyAuthRequestHandler( > const std::string& client, > const std::string& version, > DataReductionProxyParams* params); > > void SetKey(const std::string& key); Done.
lgtm, with nit. https://codereview.chromium.org/430643002/diff/80001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/80001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:24: // android webview. Android
On 2014/08/01 16:05:19, bengr1 wrote: > lgtm, with nit. > > https://codereview.chromium.org/430643002/diff/80001/components/data_reductio... > File > components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc > (right): > > https://codereview.chromium.org/430643002/diff/80001/components/data_reductio... > components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:24: > // android webview. > Android Also, add more detail to the CL description and add sgurun to review the android_webview files.
sgurun: android_webview/* https://codereview.chromium.org/430643002/diff/80001/components/data_reductio... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/80001/components/data_reductio... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:24: // android webview. On 2014/08/01 16:05:18, bengr1 wrote: > Android Done.
https://codereview.chromium.org/430643002/diff/100001/chrome/browser/net/spdy... File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc (right): https://codereview.chromium.org/430643002/diff/100001/chrome/browser/net/spdy... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:51: } nit: you don't need the braces. https://codereview.chromium.org/430643002/diff/100001/chrome/browser/net/spdy... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:52: version_parts.erase(version_parts.begin(), version_parts.begin() + 2); nit: isn't the rest of the function just: return version_parts[2] + version_parts[3] ? https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:25: const char kProtocolVersion[] = "0"; name this kAndroidWebViewProtocolVersion and wrap it in #if defined(OS_ANDROID) or whatever is appropriate? https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h (right): https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:36: explicit DataReductionProxyAuthRequestHandler( nit: no longer explicit. https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:52: // those platforms. Client is the canonical name for the client. Client names Update the comment...
https://codereview.chromium.org/430643002/diff/100001/chrome/browser/net/spdy... File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc (right): https://codereview.chromium.org/430643002/diff/100001/chrome/browser/net/spdy... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:51: } On 2014/08/01 19:11:57, Lei Zhang wrote: > nit: you don't need the braces. Done. https://codereview.chromium.org/430643002/diff/100001/chrome/browser/net/spdy... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:52: version_parts.erase(version_parts.begin(), version_parts.begin() + 2); On 2014/08/01 19:11:57, Lei Zhang wrote: > nit: isn't the rest of the function just: return version_parts[2] + > version_parts[3] ? Ya I had this originally and like it better. Switching back. https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:25: const char kProtocolVersion[] = "0"; On 2014/08/01 19:11:57, Lei Zhang wrote: > name this kAndroidWebViewProtocolVersion and wrap it in #if defined(OS_ANDROID) > or whatever is appropriate? Done. https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h (right): https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:36: explicit DataReductionProxyAuthRequestHandler( On 2014/08/01 19:11:57, Lei Zhang wrote: > nit: no longer explicit. Done. https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:52: // those platforms. Client is the canonical name for the client. Client names On 2014/08/01 19:11:57, Lei Zhang wrote: > Update the comment... Done.
chrome/ lgtm https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:25: const char kProtocolVersion[] = "0"; On 2014/08/01 20:35:26, megjablon wrote: > On 2014/08/01 19:11:57, Lei Zhang wrote: > > name this kAndroidWebViewProtocolVersion and wrap it in #if > defined(OS_ANDROID) > > or whatever is appropriate? > > Done. Same for the header file? https://codereview.chromium.org/430643002/diff/140001/chrome/browser/net/spdy... File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc (right): https://codereview.chromium.org/430643002/diff/140001/chrome/browser/net/spdy... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:8: #include "base/strings/string_util.h" no longer needed.
https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... File components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc (right): https://codereview.chromium.org/430643002/diff/100001/components/data_reducti... components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:25: const char kProtocolVersion[] = "0"; On 2014/08/01 20:43:15, Lei Zhang wrote: > On 2014/08/01 20:35:26, megjablon wrote: > > On 2014/08/01 19:11:57, Lei Zhang wrote: > > > name this kAndroidWebViewProtocolVersion and wrap it in #if > > defined(OS_ANDROID) > > > or whatever is appropriate? > > > > Done. > > Same for the header file? Done. https://codereview.chromium.org/430643002/diff/140001/chrome/browser/net/spdy... File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc (right): https://codereview.chromium.org/430643002/diff/140001/chrome/browser/net/spdy... chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:8: #include "base/strings/string_util.h" On 2014/08/01 20:43:15, Lei Zhang wrote: > no longer needed. Done.
https://codereview.chromium.org/430643002/diff/160001/android_webview/browser... File android_webview/browser/aw_browser_context.cc (right): https://codereview.chromium.org/430643002/diff/160001/android_webview/browser... android_webview/browser/aw_browser_context.cc:108: data_reduction_proxy::kAndroidWebViewProtocolVersion, why do you want to have a different protocol version for webview vs. chrome? After all it is client (data reduction proxy component) & server that wants to be compatible
https://codereview.chromium.org/430643002/diff/160001/android_webview/browser... File android_webview/browser/aw_browser_context.cc (right): https://codereview.chromium.org/430643002/diff/160001/android_webview/browser... android_webview/browser/aw_browser_context.cc:108: data_reduction_proxy::kAndroidWebViewProtocolVersion, On 2014/08/04 21:46:54, sgurun wrote: > why do you want to have a different protocol version for webview vs. chrome? > After all it is client (data reduction proxy component) & server that wants to > be compatible himm safebrowsing signals is I think the reason? lgtm
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/megjablon@chromium.org/430643002/160001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37284) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42310) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by megjablon@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37294) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/megjablon@chromium.org/430643002/160001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37309) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42334) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37328) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/megjablon@chromium.org/430643002/160001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37712) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42877) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by megjablon@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37735) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/megjablon@chromium.org/430643002/160001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38083) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/43289) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38098)
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/megjablon@chromium.org/430643002/200001
Message was sent while issue was closed.
Change committed as 287970 |
