Issue 43064: Revert the change in installer.cc to use MoveFile instead of CopyFile....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43064: Revert the change in installer.cc to use MoveFile instead of CopyFile.... (Closed)

Created:
11 years, 9 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/169/src/

Visibility:
Public.

Description

Revert the change in installer.cc to use MoveFile instead of CopyFile. MoveFile fails across volumes, and many people have %TMP% on a different volume than %LOCALAPPDATA%. TBR= huanr BUG=8505 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11414

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	chrome/installer/setup/install.cc	View		3 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages