Issue 430593002: MIPS: Clean up name distinction between Keyed ICs and Element Handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430593002: MIPS: Clean up name distinction between Keyed ICs and Element Handlers (Closed)

Created:
6 years, 4 months ago by akos.palfi.imgtec

Modified:
6 years, 4 months ago

Reviewers:
balazs.kilvady, dusmil.imgtec, Toon Verwaest, danno, gergely.kis.imgtec, paul.l...

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

MIPS: Clean up name distinction between Keyed ICs and Element Handlers Port r22679 (c6e3041b) BUG= R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=22685

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -10 lines)			Patch
M	src/mips/ic-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	3 chunks	+4 lines, -4 lines	1 comment	Download
M	src/mips64/ic-mips64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips64/macro-assembler-mips64.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/mips64/stub-cache-mips64.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

paul.l...

LGTM, please fix nit on landing. https://codereview.chromium.org/430593002/diff/1/src/mips/stub-cache-mips.cc File src/mips/stub-cache-mips.cc (right): https://codereview.chromium.org/430593002/diff/1/src/mips/stub-cache-mips.cc#newcode1132 src/mips/stub-cache-mips.cc:1132: IC_Utility(IC::kStorePropertyWithInterceptor), isolate()); nit: ...

6 years, 4 months ago (2014-07-29 20:32:11 UTC) #2

akos.palfi.imgtec

6 years, 4 months ago (2014-07-29 20:47:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22685 (presubmit successful).

Expand Messages | Collapse Messages