components/translate/content/renderer/data_file_renderer_cld_data_provider.cc - Issue 430583005: Make VEA test support videos with different coded size and visible size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

Issue 430583005: Make VEA test support videos with different coded size and visible size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use scope_ptr for MemoryMappedFile object Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/files/memory_mapped_file_win.cc ('K') | « chrome/renderer/spellchecker/hunspell_engine.cc ('k') | content/common/gpu/media/video_encode_accelerator_unittest.cc » ('j') | media/base/video_frame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

diff --git a/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc b/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

index b7a6ad27a2ec83391230007106725695ebd34bac..8c9a96a1134116b2384e761e19446dbeb6550931 100644

--- a/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

+++ b/components/translate/content/renderer/data_file_renderer_cld_data_provider.cc

@@ -99,7 +99,7 @@ void DataFileRendererCldDataProvider::LoadCldData(base::File file,

// mmap the file

g_cld_mmap.Get().value = new base::MemoryMappedFile();

- bool initialized = g_cld_mmap.Get().value->Initialize(file.Pass());

+ bool initialized = g_cld_mmap.Get().value->Initialize(file.Pass(), false);

if (!initialized) {

LOG(ERROR) << "mmap initialization failed";

delete g_cld_mmap.Get().value;