Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3230)

Unified Diff: base/files/memory_mapped_file.cc

Issue 430583005: Make VEA test support videos with different coded size and visible size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments of patch set 10 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/memory_mapped_file.cc
diff --git a/base/files/memory_mapped_file.cc b/base/files/memory_mapped_file.cc
index 745a5ff1f4524f944823c244249836b6b52bf9a3..2d6ea71e8621297e9ad05b681187bb8217f32454 100644
--- a/base/files/memory_mapped_file.cc
+++ b/base/files/memory_mapped_file.cc
@@ -42,7 +42,7 @@ bool MemoryMappedFile::Initialize(const FilePath& file_name) {
return false;
}
- if (!MapFileRegionToMemory(Region::kWholeFile)) {
+ if (!MapFileRegionToMemory(Region::kWholeFile, false)) {
CloseHandles();
return false;
}
@@ -51,16 +51,24 @@ bool MemoryMappedFile::Initialize(const FilePath& file_name) {
}
bool MemoryMappedFile::Initialize(File file) {
- return Initialize(file.Pass(), Region::kWholeFile);
+ return Initialize(file.Pass(), Region::kWholeFile, false);
}
bool MemoryMappedFile::Initialize(File file, const Region& region) {
+ return Initialize(file.Pass(), region, false);
+}
+
+bool MemoryMappedFile::Initialize(File file, bool write) {
+ return Initialize(file.Pass(), Region::kWholeFile, write);
+}
+
+bool MemoryMappedFile::Initialize(File file, const Region& region, bool write) {
if (IsValid())
return false;
file_ = file.Pass();
- if (!MapFileRegionToMemory(region)) {
+ if (!MapFileRegionToMemory(region, write)) {
CloseHandles();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698