Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2530)

Unified Diff: base/files/file.cc

Issue 430583005: Make VEA test support videos with different coded size and visible size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments of patch set 7 and 8 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/file.cc
diff --git a/base/files/file.cc b/base/files/file.cc
index ea8dbf27ac1770d88fc6ce933a4bdd331820d2d9..7867d63878f8c2d0d763e76c6ba7a647402882fa 100644
--- a/base/files/file.cc
+++ b/base/files/file.cc
@@ -19,14 +19,16 @@ File::Info::~Info() {
File::File()
: error_details_(FILE_ERROR_FAILED),
created_(false),
- async_(false) {
+ async_(false),
+ flags_(0) {
}
#if !defined(OS_NACL)
File::File(const FilePath& name, uint32 flags)
: error_details_(FILE_OK),
created_(false),
- async_(false) {
+ async_(false),
+ flags_(0) {
Initialize(name, flags);
}
#endif
@@ -35,7 +37,8 @@ File::File(PlatformFile platform_file)
: file_(platform_file),
error_details_(FILE_OK),
created_(false),
- async_(false) {
+ async_(false),
+ flags_(0) {
#if defined(OS_POSIX)
DCHECK_GE(platform_file, -1);
#endif
@@ -44,14 +47,16 @@ File::File(PlatformFile platform_file)
File::File(Error error_details)
: error_details_(error_details),
created_(false),
- async_(false) {
+ async_(false),
+ flags_(0) {
}
File::File(RValue other)
: file_(other.object->TakePlatformFile()),
error_details_(other.object->error_details()),
created_(other.object->created()),
- async_(other.object->async_) {
+ async_(other.object->async_),
+ flags_(other.object->flags_) {
}
File::~File() {
@@ -66,6 +71,7 @@ File& File::operator=(RValue other) {
error_details_ = other.object->error_details();
created_ = other.object->created();
async_ = other.object->async_;
+ flags_ = other.object->flags_;
}
return *this;
}
@@ -76,6 +82,7 @@ void File::Initialize(const FilePath& name, uint32 flags) {
error_details_ = FILE_ERROR_ACCESS_DENIED;
return;
}
+ flags_ = flags;
InitializeUnsafe(name, flags);
}
#endif

Powered by Google App Engine
This is Rietveld 408576698