base/files/memory_mapped_file_posix.cc - Issue 430583005: Make VEA test support videos with different coded size and visible size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/memory_mapped_file_posix.cc

Issue 430583005: Make VEA test support videos with different coded size and visible size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address rvargas review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/common/gpu/media/video_encode_accelerator_unittest.cc » ('j') | content/common/gpu/media/video_encode_accelerator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/files/memory_mapped_file_posix.cc

diff --git a/base/files/memory_mapped_file_posix.cc b/base/files/memory_mapped_file_posix.cc

index ebf38779f039708835242eb19ed7223927a28f40..7258bffa6cd0964d57ac1c4b22384be40e9937d2 100644

--- a/base/files/memory_mapped_file_posix.cc

+++ b/base/files/memory_mapped_file_posix.cc

@@ -62,7 +62,7 @@ bool MemoryMappedFile::MapFileRegionToMemory(

data_ = static_cast<uint8*>(mmap(NULL,

map_size,

- PROT_READ,

+ PROT_READ | PROT_WRITE,

henryhsu 2014/08/27 07:22:40 The read/write permission setting should be accord

MAP_SHARED,

file_.GetPlatformFile(),

map_start));